-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prometheus_flask_exporter #233
Conversation
@magnarem this should not conflict with the catalog-rebuilder-flask metrics endpoint right? because dmci has its own container port (8000) as far as I understand, and that's where these /metrics will end up |
I think it should be no problem. The k8s nginx in front of dmci, should handle request dmci.s-enda.k8s.met.no/metrics og catalog-rebuilder.s-enda.k8s.met.no/metrics to the right ones...If unsure, maybe the k8s people can give a better answer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's see if it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if it works in dev
I think we'll need to add annotations to the |
Yes, for promethues to see the metrics, you will have to add the right anotations. The dmci pod did not start properly. Here is the error from the dmci startup log:
You will need to add the Add it under: |
🙃 I added it to the requirements file and forgot about that ... I will open a PR to fix this |
patch #234 |
Summary: extract metrics via prometheus_flask_exporter
Related issue:
#220
Suggested reviewer(s):
Reviewer checklist:
The checklist is based on the S-ENDA conventions and definition of done (see General Conventions). The above points are not necessarily relevant to all contributions. In that case, please add a short explanation to help the reviewer.